Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repl): fix tab handler on windows #14931

Merged
merged 1 commit into from Jun 22, 2022
Merged

chore(repl): fix tab handler on windows #14931

merged 1 commit into from Jun 22, 2022

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Jun 21, 2022

More info here #14927

I did not test my changes on windows but it should theoretically work. Hopefully someone with a windows machine can test it.

dsherret
dsherret approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with this, @sigmaSd! I tested on Windows and this is much better. Also this passes the pty_tab_handler test locally.

@dsherret dsherret merged commit efaa149 into denoland:main Jun 22, 2022
aslilac pushed a commit that referenced this pull request Jun 23, 2022
@sigmaSd @aslilac
fix(repl): use spaces for tab handler on windows (#14931)
7623ce8 
There is a bug in rustyline with tabs on Windows, so we insert spaces for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sigmaSd @dsherret