Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): Ignore TS2306 #14940

Merged
merged 3 commits into from Jun 23, 2022
Merged

fix(check): Ignore TS2306 #14940

merged 3 commits into from Jun 23, 2022

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jun 22, 2022 •
edited

Fixes #14937.

@nayeemrmn nayeemrmn marked this pull request as ready for review June 23, 2022 15:34
@nayeemrmn
Copy link
Collaborator Author

@dsherret Please review

dsherret
dsherret approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @nayeemrmn!

@dsherret dsherret merged commit ef7bc5e into denoland:main Jun 23, 2022
aslilac pushed a commit that referenced this pull request Jun 23, 2022
@nayeemrmn @aslilac
fix(check): ignore TS2306 (#14940)
e6365cc 
Fixes a regression where this type checking error was being surfaced in certain scenarios.
@nayeemrmn nayeemrmn deleted the ts2306-ignore branch June 25, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 TS2306 "not a module" errors from CDN type files
2 participants
@nayeemrmn @dsherret