Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): --watch arg is stable #14970

Merged
merged 1 commit into from
Jun 26, 2022
Merged

fix(docs): --watch arg is stable #14970

merged 1 commit into from
Jun 26, 2022

Conversation

GJZwiers
Copy link
Contributor

This updates the docs in cli/flags.rs to no longer mention --watch mode as unstable.

@GJZwiers
Copy link
Contributor Author

Not sure if this is right actually, I seem to recall there were some different rules for unstable and CLI flags.

bartlomieju
bartlomieju approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, there are many users of file watcher that are happy, there's no point in keeping that prefix in help text.

@bartlomieju bartlomieju merged commit 2d1c48c into denoland:main Jun 26, 2022
@GJZwiers GJZwiers deleted the update_watch_arg_doc branch June 27, 2022 07:32
dsherret pushed a commit to dsherret/deno that referenced this pull request Jun 30, 2022
@GJZwiers @dsherret
fix(docs): --watch arg is stable (denoland#14970)
1bd024f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GJZwiers @bartlomieju