-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(task): remove --no-config as task subcommand argument #14983
fix(task): remove --no-config as task subcommand argument #14983
Conversation
cli/flags.rs
Outdated
Arg::new("config") | ||
.short('c') | ||
.long("config") | ||
.value_name("FILE") | ||
.help("Specify the configuration file") | ||
.long_help(CONFIG_HELP.as_str()) | ||
.takes_value(true) | ||
.value_hint(ValueHint::FilePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider splitting config_args()
into config_arg
and no_config_arg
and applying them to all relevant subcommands. I think this is better than duplicating arg definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but besides LGTM
cli/args/flags.rs
Outdated
@@ -2997,6 +3003,14 @@ fn config_args_parse(flags: &mut Flags, matches: &ArgMatches) { | |||
}; | |||
} | |||
|
|||
fn task_args_parse(flags: &mut Flags, matches: &ArgMatches) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please inline contents of this function into task_parse
, there's no need for a separate function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Fixes #14971.