Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime/ExitCode default): derive default for deno_runtime::ExitCode #15017

Merged
merged 3 commits into from
Jun 30, 2022
Merged

fix(runtime/ExitCode default): derive default for deno_runtime::ExitCode #15017

merged 3 commits into from
Jun 30, 2022

Conversation

curtisallen
Copy link
Contributor

Fixes #15016

Embeders can now

let exit_code: ExitCode = Default::default();
...
deno_runtime::ops::os::init(exit_code.clone())
...

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit d5ef14e into denoland:main Jun 30, 2022
dsherret pushed a commit to dsherret/deno that referenced this pull request Jun 30, 2022
@curtisallen @dsherret
fix(runtime): derive default for deno_runtime::ExitCode (denoland#15017)
1025be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno_runtime::ExitCode should derive Default
3 participants
@curtisallen @CLAassistant @bartlomieju