Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ops): fast path for SMI return values #15033

Merged
merged 1 commit into from Jul 1, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jul 1, 2022

This commits enables optimization for
ops with return type u8, u16, u32
and deno_core::ResourceId (And their
Result wrappers). Only applies to sync
ops that can skip the serde_v8 layer AOT.

Time spent setting a ReturnValue is cut
by half. This can also be done for i32 types.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@littledivy littledivy merged commit 4e7abf4 into denoland:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants