Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build deno under node_modules folder #1555

Merged
merged 1 commit into from Jan 21, 2019
Merged

fix: build deno under node_modules folder #1555

merged 1 commit into from Jan 21, 2019

Conversation

caijw
Copy link
Contributor

@caijw caijw commented Jan 20, 2019

fix issue:
#1536

refer to:
https://github.com/TypeStrong/ts-node#cli-and-programmatic-options

ts-node provides CLI option --skip-ignore to skip ignore checks (TS_NODE_SKIP_IGNORE, default: false).

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

ry
ry approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

Tbh I don’t know what this option does but if it’s passing the tests it should be fine ...

@ry ry merged commit 106fe1f into denoland:master Jan 21, 2019
@caijw caijw mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caijw @CLAassistant @ry