Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): do not attempt to emit non-emitable files #15562

Merged
merged 2 commits into from
Aug 23, 2022
Merged

fix(cache): do not attempt to emit non-emitable files #15562

merged 2 commits into from
Aug 23, 2022

Conversation

dsherret
Copy link
Member

Closes #15558

lucacasonato
lucacasonato approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 362af63 into denoland:main Aug 23, 2022
@dsherret dsherret deleted the fix_deno_cache_json_imports branch August 23, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeemrmn nayeemrmn nayeemrmn left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno cache fails with JSON imports
3 participants
@dsherret @lucacasonato @nayeemrmn