perf(url): return early if url has no query string #15856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change returns early if the url being parsed has no query string. This gives a nice performance improvement when tested on Ubuntu 22.04 docker in unprivileged mode:
I ran wpt tests as follows and all are passing.
I can't bench right now on Mac or Windows so if anyone can verify they can see same thing there, that would be great.
this is my first Deno PR so let me know if i have missed something out.