Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): binary entrypoint for .js or no extension #15900

Merged
merged 5 commits into from Sep 14, 2022
Merged

fix(npm): binary entrypoint for .js or no extension #15900

merged 5 commits into from Sep 14, 2022

Conversation

bartlomieju
Copy link
Member

Fix running deno run npm:<package_name> that use .js extension or no extension.

Closes #15898

Merge on approval

dsherret
dsherret approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 7b98282 into denoland:main Sep 14, 2022
@bartlomieju bartlomieju deleted the fix_npm_bin branch September 14, 2022 18:54
cjihrig pushed a commit that referenced this pull request Sep 15, 2022
@bartlomieju @cjihrig
fix(npm): binary entrypoint for .js or no extension (#15900)
3c6652d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm: Running TypeScript/tsc causes require is not defined
3 participants
@bartlomieju @dsherret @littledivy