Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use ntfs junctions in node_modules folder on Windows #16061

Merged
merged 3 commits into from Sep 27, 2022

Conversation

dsherret
Copy link
Member

Does what pnpm does (https://pnpm.io/faq#does-it-work-on-windows) and what was recommended in the issue.

Closes #16006

@dsherret dsherret changed the title fix: use ntfs junctions in node_modules folder on Windows fix(npm): use ntfs junctions in node_modules folder on Windows Sep 27, 2022
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/npm/resolvers/local.rs Outdated Show resolved Hide resolved
cli/npm/resolvers/local.rs Show resolved Hide resolved
@dsherret dsherret merged commit a44c83a into denoland:main Sep 27, 2022
@dsherret dsherret deleted the fix_use_junctions_on_windows branch September 27, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local node_modules - Use junctions instead of symlinks on Windows
3 participants