fix(npm): handle json files in require #16125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Oct 1, 2022
kidonng
reviewed
Oct 2, 2022
Comment on lines
+753
to
+758
| if media_type == MediaType::Json { | ||
| return Ok(CjsAnalysis { | ||
| exports: vec![], | ||
| reexports: vec![], | ||
| }); | ||
| } |
There was a problem hiding this comment.
Isn't this just going to make programs expecting JSON data fail at runtime? I'm not sure how aligned to CJS Deno is going to be in compat mode though.
There was a problem hiding this comment.
How so? I added a test that requires data from JSON file and it works as expected.
There was a problem hiding this comment.
I see, I misunderstood the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16118