Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/cache): close resource on error #16129

Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix(ext/cache): close resource on error #16129

merged 1 commit into from
Oct 3, 2022

Conversation

marcosc90
Copy link
Contributor

cache.put leaks resources if there's an error while reading.

satyarohith
satyarohith approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@satyarohith satyarohith merged commit e2990be into denoland:main Oct 3, 2022
@marcosc90 marcosc90 deleted the fix-cache-rid-leak branch October 3, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@satyarohith satyarohith satyarohith approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcosc90 @cjihrig @satyarohith @littledivy