fix(ext/cache): illegal constructor #16205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
reviewed
Oct 8, 2022
marcosc90
commented
Oct 8, 2022
axetroy
reviewed
Oct 8, 2022
cli/tests/unit/cache_api_test.ts
Outdated
| Deno.test(function cacheIllegalConstructor() { | ||
| // @ts-ignore illegal constructor | ||
| assertThrows(() => new Cache(), TypeError, "Illegal constructor"); | ||
| // @ts-ignore illegal constructor |
There was a problem hiding this comment.
// @ts-expect-error maybe better?
bartlomieju
pushed a commit
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16199
There is no
constructorininterface Cache {}https://w3c.github.io/ServiceWorker/#cache-interface