Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): "Failed to load the import map" #16224

Merged
merged 2 commits into from
Oct 16, 2022
Merged

fix(lsp): "Failed to load the import map" #16224

merged 2 commits into from
Oct 16, 2022

Conversation

chibat
Copy link
Contributor

@chibat chibat commented Oct 9, 2022

I believe it is related to denoland/vscode_deno#718

The following reproduction procedure fails to load import map by deno lsp.

$ mkdir -p my-project/.vscode
$ echo '{ "deno.enable": true }' > my-project/.vscode/settings.json
$ cd my-project/
$ code .

open .vscode/settings.json(start deno lsp)

We get the following error message.

Failed to load the import map at: file:///home/chiba/my-project. [Is a directory (os error 21)]
deno-lsp-error

I have added a check for empty characters.

@chibat
Copy link
Contributor Author

chibat commented Oct 9, 2022

Sorry. I will check the test error.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 2b35cb3 into denoland:main Oct 16, 2022
bartlomieju added a commit that referenced this pull request Oct 17, 2022
Ref: denoland/vscode_deno#718

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants