feat(install): support npm specifiers #16634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 14, 2022
| worker.preload_main_module().await?; | ||
| let ps = ProcState::build(flags.clone()).await?; | ||
| // ensure the module is cached | ||
| load_and_type_check(&ps, &[install_flags.module_url.clone()]).await?; |
There was a problem hiding this comment.
Seemed like a lot of ceremony. Can we just use this instead?
There was a problem hiding this comment.
If the tests pass I think it's fine
dsherret
commented
Nov 14, 2022
| @@ -189,7 +205,7 @@ pub fn uninstall(name: String, root: Option<PathBuf>) -> Result<(), AnyError> { | |||
|
|
|||
| // There might be some extra files to delete | |||
| for ext in ["tsconfig.json", "lock.json"] { | |||
| file_path = file_path.with_extension(ext); | |||
| let file_path = file_path.with_extension(ext); | |||
There was a problem hiding this comment.
Bug here. It would do file.tsconfig.json then file.tsconfig.lock.json. Now that's fixed.
dsherret
commented
Nov 14, 2022
| @@ -995,10 +1098,14 @@ mod tests { | |||
| } | |||
|
|
|||
| // create extra files | |||
| file_path = file_path.with_extension("tsconfig.json"); | |||
| File::create(&file_path).unwrap(); | |||
| file_path = file_path.with_extension("lock.json"); | |||
There was a problem hiding this comment.
Bug was also happening here where it would do echo_test.tsconfig.json then echo_test.tsconfig.lock.json, which is why this test didn't catch the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports npm specifiers for
deno install. This will by default always use a lockfile (which is generated on first run) unless--no-lockis specified.