feat(http): return WebSocketStream from upgradeWebSocket #16732
+367
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The WSS accessor needs to be locked behind --unstable. |
|
@lucacasonato done |
bartlomieju
reviewed
Dec 13, 2022
cli/dts/lib.deno.unstable.d.ts
Outdated
| * request. | ||
| * | ||
| * @category Web Sockets */ | ||
| export interface WebSocketUpgrade { |
There was a problem hiding this comment.
It seems this is not used anywhere?
There was a problem hiding this comment.
it overloads the same named interface as in lib.deno.ns.d.ts
|
Would it be possible to test this API against this issue? #17332 In Deno 1.29.2 |
# Conflicts: # runtime/ops/runtime.rs
# Conflicts: # cli/tsc/dts/lib.deno.unstable.d.ts # ext/flash/01_http.js # ext/http/01_http.js # ext/websocket/02_websocketstream.js
crowlKats
changed the title
crowlKats
changed the title
bartlomieju
requested changes
Mar 17, 2023
bartlomieju
reviewed
Mar 18, 2023
There was a problem hiding this comment.
@crowlKats looks good, but I'd like to see a test that verified that either socket or stream can be used
|
@bartlomieju there is a test for that already |
# Conflicts: # ext/flash/01_http.js # ext/http/01_http.js # ext/websocket/02_websocketstream.js # runtime/ops/runtime.rs
This was referenced Aug 25, 2023
Signed-off-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14064