feat(repl): run "deno repl" with no permissions #16795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsherret please take a look |
|
@bartlomieju this broke the pty_complete_imports test. It hangs now. Edit: took a look and easy fix #16992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes "deno repl" command to run with no permissions by default
and accept "--allow-*" flags.
This change is dictated by the fact that currently there is no way to run REPL with
limited permissions. Technically it's a breaking change in the CLI command, but
there's agreement in the team that it has merit and it's a good solution.
Running just "deno" command still starts the REPL with full permissions allowed,
but now a banner is printed to inform users about that:
Ref #16770 (comment)
Ref #12665