Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade/windows): show informative message on access denied error #16887

Merged
merged 8 commits into from
Dec 2, 2022
Merged

fix(upgrade/windows): show informative message on access denied error #16887

merged 8 commits into from
Dec 2, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 1, 2022

Closes #16886

ry
ry reviewed Dec 2, 2022
View reviewed changes
cli/tools/upgrade.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 83bc8c4 into denoland:main Dec 2, 2022
@dsherret dsherret deleted the fix_add_message_deno_upgrade_windows branch December 2, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed on update on Windows due to access denied error
2 participants
@dsherret @ry