Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unstable: remove Deno.spawn, Deno.spawnSync, Deno.spawnChild APIs #16893

Merged
merged 8 commits into from Dec 9, 2022
Merged

unstable: remove Deno.spawn, Deno.spawnSync, Deno.spawnChild APIs #16893

merged 8 commits into from Dec 9, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 1, 2022 •
edited

This commit removes three unstable Deno APIs:

  • "Deno.spawn()"
  • "Deno.spawnSync()"
  • "Deno.spawnChild()"

These APIs were replaced by a unified "Deno.Command" API.

@bartlomieju bartlomieju added this to the 1.29 milestone Dec 1, 2022
@iuioiua
Copy link
Collaborator

iuioiua commented Dec 1, 2022

Should Deno.run also be removed?

@bartlomieju
Copy link
Member Author

Should Deno.run also be removed?

No, it's a stable API that can't be removed until Deno 2.0 happens. We will deprecate it though, once we stabilize Deno.Command.

@iuioiua
Copy link
Collaborator

iuioiua commented Dec 1, 2022

No, it's a stable API that can't be removed until Deno 2.0 happens. We will deprecate it though, once we stabilize Deno.Command.

Oh, I thought it was unstable for some reason...

@bartlomieju bartlomieju changed the title [WIP] unstable: remove Deno.spawn, Deno.spawnSync, Deno.spawnChild APIs unstable: remove Deno.spawn, Deno.spawnSync, Deno.spawnChild APIs Dec 2, 2022
dsherret
dsherret approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit cb6700f into denoland:main Dec 9, 2022
@bartlomieju bartlomieju deleted the remove_spawn_api branch December 9, 2022 15:43
@dsherret dsherret mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @iuioiua @dsherret