Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add Response.json static method #17061

Merged
merged 2 commits into from
Dec 15, 2022
Merged

fix: re-add Response.json static method #17061

merged 2 commits into from
Dec 15, 2022

Conversation

crowlKats
Copy link
Member

Same as #16040

ry
ry approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tho I wish we had a way to do these check tests without starting up the whole process.

@kt3k
Copy link
Member

kt3k commented Dec 15, 2022

I wish we had a way to do these check tests without starting up the whole process.

All lib.dom.d.ts related type checks can be included in the same file. Maybe we should rename the test case to check_custom_dom_patches?

@dsherret dsherret merged commit 50c7526 into denoland:main Dec 15, 2022
@crowlKats crowlKats deleted the fix_response branch December 15, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crowlKats @kt3k @ry @dsherret