Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): semiColons: false - handle prop with following generator and do while with no block body #17567

Merged
merged 2 commits into from
Jan 28, 2023
Merged

fix(fmt): semiColons: false - handle prop with following generator and do while with no block body #17567

merged 2 commits into from
Jan 28, 2023

Conversation

dsherret
Copy link
Member

See more reasons to just use semi-colons here: #17559 (comment)

Closes #17559

@dsherret dsherret changed the title fix(fmt): asi - handle prop with following generator and do while with no block body fix(fmt): semiColons: false - handle prop with following generator and do while with no block body Jan 28, 2023
bartlomieju
bartlomieju approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 1803df7 into denoland:main Jan 28, 2023
@dsherret dsherret deleted the fix_fmt_asi branch January 28, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASI - Deno fmt panic on property preceeding generator method
2 participants
@dsherret @bartlomieju