Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove have_unpolled_ops on rt state #17601

Merged
merged 3 commits into from Jan 31, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jan 30, 2023

It's not needed - !state.have_unpolled_ops.is_empty() does the same thing.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great fix

@bartlomieju bartlomieju merged commit e85ca8b into denoland:main Jan 31, 2023
@bartlomieju bartlomieju deleted the remove_have_unpolled_ops branch January 31, 2023 00:17
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Feb 2, 2023
bartlomieju added a commit that referenced this pull request Feb 2, 2023
…17631)

This reverts commit e85ca8b.

This commit caused a huge spike in various benchmarks we track at
https://deno.land/benchmarks
littledivy pushed a commit that referenced this pull request Feb 3, 2023
…17631)

This reverts commit e85ca8b.

This commit caused a huge spike in various benchmarks we track at
https://deno.land/benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants