refactor: reland "preserve ProcState::file_fetcher between restarts" #17636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Feb 3, 2023
runtime/ops/signal.rs
Outdated
| @@ -298,7 +298,7 @@ pub fn signal_str_to_int(s: &str) -> Result<libc::c_int, AnyError> { | |||
| "SIGINFO" => Ok(29), | |||
| "SIGUSR1" => Ok(30), | |||
| "SIGUSR2" => Ok(31), | |||
| _ => Err(type_error(format!("Invalid signal: {s}"))), | |||
| _ => Err(type_error(format!("Invalid signal: {}", s))), | |||
There was a problem hiding this comment.
Can you revert these back? It will fail when running clippy on mac.
dsherret
changed the title
dsherret
changed the title
dsherret
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
LGTM once the mac clippy issue is fixed. Thanks @nayeemrmn!
bartlomieju
pushed a commit
that referenced
this pull request
Feb 6, 2023
…17636) Just some watcher init step that I thought would be "cloned over" but needs to be done again on reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some watcher init step that I thought would be "cloned over" but needs to be done again on reset (b1d2c0e)
Reland #15466
Add test for #17584