New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/node): embed std/node into the snapshot #17724
Conversation
There are currently 3 blockers that we need to tackle:
references to replace imports of functionality outside of
EDIT: We can now successfully take a snapshot of |
…into ext_node_embed
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - after landing this we are leaving main in purgatory with all this code being unused. However I think it makes sense given the size of this patch.
Blocked on #17735 |
This commit moves "deno_std/node" in "ext/node" crate. The code is
transpiled and snapshotted during the build process.
During the first pass a minimal amount of work was done to create the snapshot,
a lot of code in "ext/node" depends on presence of "Deno" global. This code
will be gradually fixed in the follow up PRs to migrate it to import relevant
APIs from "internal:" modules.
Currently the code from snapshot is not used in any way, and all Node/npm
compatibility still uses code from "https://deno.land/std/node" (or from the
location specified by "DENO_NODE_COMPAT_URL"). This will also be
handled in a follow up PRs.