feat(fs): support FileInfo.dev on Windows #18073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Mar 8, 2023
aapoalas
previously requested changes
Mar 14, 2023
bartlomieju
force-pushed
the
windows_stat_dev
branch
from
174b54a
to
07cde82
Compare
bartlomieju
changed the title
|
Yay! Can we revert the part of this change that sets everything to 0 for windows? The null->zero should happen in ext/node. Also this is a breaking API change. |
bartlomieju
added a commit
that referenced
this pull request
Mar 16, 2023
Addresses feedback from #18073 (comment). Reverts changes to `FileInfo` fields that are not available on Windows making them `null`. Only `FileInfo.dev` is non-null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for retrieving
devinformationwhen stating files on Windows.
Additionally
Deno.FileInfointerfaces was changed to alwaysreturn 0 for fields that we don't retrieve information for on Windows.
Closes #18053