fix(npm): show a progress bar when initializing the node_modules folder #18136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While you're working on it, could you also change the progress bar to be lazy-initiated (ie. on the first usage), it shows up on startup flamegraphs even though it's not used. |
dsherret
added a commit
that referenced
this pull request
Mar 13, 2023
This has been bothering me for a while and it became more painful while working on #18136 because injecting the shared progress bar became very verbose. Basically we should move the creation of all these npm structs up to a higher level. This is a stepping stone for a future refactor where we can improve how we create all our structs.
bartlomieju
approved these changes
Mar 13, 2023
Comment on lines
+289
to
+292
| // only check if progress bars are supported once we go | ||
| // to update so that we lazily initialize the progress bar | ||
| if ProgressBar::are_supported() { | ||
| let entry = self.inner.add_entry(kind, msg.to_string()); |
There was a problem hiding this comment.
Nice, thanks for fixing this!
kt3k
pushed a commit
that referenced
this pull request
Mar 16, 2023
This has been bothering me for a while and it became more painful while working on #18136 because injecting the shared progress bar became very verbose. Basically we should move the creation of all these npm structs up to a higher level. This is a stepping stone for a future refactor where we can improve how we create all our structs.
kt3k
pushed a commit
that referenced
this pull request
Mar 16, 2023
…er (#18136) Creating the node_modules folder when the packages are already downloaded can take a bit of time and not knowing what is going on can be confusing. It's better to show a progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the node_modules folder when the packages are already downloaded can take a bit of time and not knowing what is going on can be confusing. It's better to show a progress bar.
2023-03-11_16-24-55.mp4
Note: Right now this does not look good when a package gets downloaded at the same time. I'll refactor the progress bars on Monday.