Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test for macOS shared libraries #18244

Merged
merged 2 commits into from
Mar 17, 2023
Merged

chore: add test for macOS shared libraries #18244

merged 2 commits into from
Mar 17, 2023

Conversation

littledivy
Copy link
Member

Closes #18243

@littledivy littledivy enabled auto-merge (squash) March 17, 2023 05:36
@littledivy littledivy merged commit 0eabd2c into denoland:main Mar 17, 2023
@lucacasonato
Copy link
Member

@littledivy Please move this test to a different file. integration/mod.rs is not meant to contain any tests.

@ry
Copy link
Member

ry commented Mar 17, 2023 •
edited

Nice test @littledivy - when you address Luca's comment, please also add a comment to the top of the file just explaining that this is to prevent inadvertently linking to more shared libs.

@littledivy littledivy mentioned this pull request Mar 18, 2023
Merged
littledivy added a commit that referenced this pull request Mar 18, 2023
@littledivy
chore(cli/tests): move macos_shared_libraries test to macos_test.rs (#…
00f4c0d 
…18268)

As per review comment in original PR:
#18244 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for shared libraries used on macOS
4 participants
@littledivy @lucacasonato @ry @aapoalas