Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(unstable): remove "Deno.serve(handler, options)" overload #18759

Merged
merged 6 commits into from Apr 26, 2023
Merged

BREAKING(unstable): remove "Deno.serve(handler, options)" overload #18759

merged 6 commits into from Apr 26, 2023

Conversation

bartlomieju
Copy link
Member

In preparation to stabilization of the API this overload was decided to be removed.

@bartlomieju bartlomieju mentioned this pull request Apr 18, 2023
Merged
dsherret
dsherret approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kt3k
kt3k approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato
Copy link
Member

lucacasonato commented Apr 25, 2023 •
edited

Do note that this breaks backwards compat with existing std/http serve signatures. Not a blocker, just wanted to make sure you're aware :)

@bartlomieju bartlomieju merged commit 1b45001 into denoland:main Apr 26, 2023
11 checks passed
@bartlomieju bartlomieju deleted the deno_serve_overload branch April 26, 2023 12:54
@littledivy littledivy mentioned this pull request Apr 29, 2023
Merged
littledivy added a commit that referenced this pull request May 1, 2023
@littledivy
chore(ext/websocket): readd autobahn|testsuite fuzzingclient (#18903)
89160e7 
This reverts commit
17d1c7e.

The `Deno.serve` signature update in
#18759 broke the testee server
right after this patch landed on `main`.
levex pushed a commit that referenced this pull request May 4, 2023
@littledivy @levex
chore(ext/websocket): readd autobahn|testsuite fuzzingclient (#18903)
ff3dc7d 
This reverts commit
17d1c7e.

The `Deno.serve` signature update in
#18759 broke the testee server
right after this patch landed on `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartlomieju @lucacasonato @kt3k @dsherret