Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show cache initialization errors if stderr is piped #18920

Merged
merged 1 commit into from May 30, 2023

Conversation

dsherret
Copy link
Member

Maybe? These don't seem worth surfacing all the time.

Closes #18918

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dsherret dsherret merged commit 42a3f52 into denoland:main May 30, 2023
11 checks passed
@dsherret dsherret deleted the fix_cache_initialization_errors branch May 30, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors initializing cache database on GH actions
3 participants