Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dts): move BroadcastChannel type to lib.deno.unstable.d.ts #19108

Merged
merged 4 commits into from May 14, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 12, 2023

BroadcastChannel is unstable in runtime, but its type is available in stable. This PR moves BroadcastChannel to lib.deno.unstable.d.ts and causes type check error when --unstable is not specified.

@kt3k kt3k requested review from dsherret, bartlomieju and ry May 13, 2023 06:04
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 6bea6b3 into denoland:main May 14, 2023
11 checks passed
@kt3k kt3k deleted the move-broadcast-channel-type-unstable branch May 14, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants