feat(node_compat): Add a close method to the FileHandle class. #19357
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Jun 4, 2023
Co-authored-by: Matt Mastracci <matthew@mastracci.com>
mmastrac
requested changes
Jun 5, 2023
|
|
||
| close(): Promise<void> { | ||
| // Note that Deno.close is not async | ||
| return Promise.resolve(Deno.close(this.fd)) |
There was a problem hiding this comment.
Looks like this just needs a semicolon to pass the linter (run tools/format.js) and we're good to go
|
Thanks for your review |
bartlomieju
pushed a commit
that referenced
this pull request
Jun 8, 2023
## WHY ref: #19165 The FileHandle class has many missing methods compared to node. Add these. ## WHAT - Add close method --------- Co-authored-by: Matt Mastracci <matthew@mastracci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
ref: #19165
The FileHandle class has many missing methods compared to node.
Add these.
WHAT