fix(ext/node): handle 'upgrade' responses

[bartlomieju]

This commit adds support for "upgrade" events in "node:http"
"ClientRequest". Currently only "Websocket" upgrades are
handled. Thanks to this change package like "npm:puppeteer"
and "npm:discord" should work.

Closes #18913
Closes #17847

[bartlomieju]

ws library is not properly closing the socket, it wait for 30s before timeout kills the program.

[crowlKats]

not a big fan that we have this option and also the op.
Is there a considerable perf difference if we do have this option and call the two ops after each other for fetch?

[bartlomieju]

Probably not - let's use this option for now - we will be rewriting all of that code to drop reqwest and we can clean it all up then.

[lucacasonato]

I think we can clean this up down the line so that we always create a FetchResponseResource that can internally either be the full response, or deconstructed into a stream (an inner enum). And FetchResponseBodyResource goes away. The first read would deconstruct automatically. This is what we used to do for HTTP too - not sure if we still do that.

That way the caller would not have to choose whether they want to deconstruction or not. Depending on which ops you use later, it either happens or not.

[lucacasonato]

I mean this: https://github.com/denoland/deno/blob/main/ext/http/lib.rs#L435

[lucacasonato]

It's ok to land as is, but we should clean this up soon.

[lucacasonato]

I guess we don't use primordials in Node code, right?

[bartlomieju]

Correct

[lucacasonato]

LGTM

[jeroendee]

@bartlomieju but how to use the puppeteer product? Using their https://github.com/puppeteer/puppeteer/tree/main#readme example script, it fails downloading the chrome testing binary (= default node behaviour).

import puppeteer from 'npm:puppeteer';

(async () => {
  // Launch the browser and open a new blank page
  const browser = await puppeteer.launch();
  const page = await browser.newPage();

  // Navigate the page to a URL
  await page.goto('https://developer.chrome.com/');

  // Set screen size
  await page.setViewport({width: 1080, height: 1024});

  // Type into search box
  await page.type('.search-box__input', 'automate beyond recorder');

  // Wait and click on first result
  const searchResultSelector = '.search-box__link';
  await page.waitForSelector(searchResultSelector);
  await page.click(searchResultSelector);

  // Locate the full title with a unique string
  const textSelector = await page.waitForSelector(
    'text/Customize and automate'
  );
  const fullTitle = await textSelector?.evaluate(el => el.textContent);

  // Print the full title
  console.log('The title of this blog post is "%s".', fullTitle);

  await browser.close();
})();

error: Uncaught Error: Could not find Chrome (ver. 114.0.5735.133). This can occur if either
 1. you did not perform an installation before running the script (e.g. `npm install`) or
 2. your cache path is incorrectly configured (which is: /Users/.../.cache/puppeteer).
For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.
    at ChromeLauncher.resolveExecutablePath (file:///Users/.../Library/Caches/deno/npm/registry.npmjs.org/puppeteer-core/20.8.3/lib/esm/puppeteer/node/ProductLauncher.js:278:27)
    at ChromeLauncher.executablePath (file:///Users/.../Library/Caches/deno/npm/registry.npmjs.org/puppeteer-core/20.8.3/lib/esm/puppeteer/node/ChromeLauncher.js:174:25)
    at ChromeLauncher.computeLaunchArguments (file:///Users/.../Library/Caches/deno/npm/registry.npmjs.org/puppeteer-core/20.8.3/lib/esm/puppeteer/node/ChromeLauncher.js:91:37)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async ChromeLauncher.launch (file:///Users/.../Library/Caches/deno/npm/registry.npmjs.org/puppeteer-core/20.8.3/lib/esm/puppeteer/node/ProductLauncher.js:57:28)
    at async file:///Users/.../ACID/40-49/44/44.E/exp-puppeteer/main.ts:5:19

Also @lucacasonato example: #18913 targeting puppeteer-core is not working against the latest puppeteer version since the BrowserFetcher has been removed since Puppeteer 20.0.0 (migrating towards using the new Chrome Testing version)

Does this changeset target npm:puppeteer OR npm:puppeteer-core compatibility?

[marvinhagemeister]

@jeroendee Something like this ensures that chrome is available before launching puppeteer:

import { DenoDir } from "https://deno.land/x/deno_cache@0.4.1/mod.ts";
import { join } from "https://deno.land/std@0.190.0/path/mod.ts";
import puppeteer, { Page, PUPPETEER_REVISIONS } from "npm:puppeteer-core";
import * as puppeteerBrowsers from "npm:@puppeteer/browsers";

async function launchPuppeteer(options: PuppeteerLaunchOptions = {}) {
  const dir = new DenoDir();
  const path = join(
    dir.root,
    "puppeteer",
    "chrome",
    PUPPETEER_REVISIONS.chrome,
  );
  const install = await puppeteerBrowsers.install({
    cacheDir: path,
    browser: puppeteerBrowsers.Browser.CHROME,
    buildId: PUPPETEER_REVISIONS.chrome,
  });

  const executablePath = puppeteerBrowsers.computeExecutablePath({
    browser: install.browser,
    buildId: install.buildId,
    cacheDir: path,
  });

  return await puppeteer.launch({
    ...options,
    executablePath,
  });
}