[help needed] Duplicate code cleaning

[zekth]

I've spotted some duplicates code in js/util.ts which was implemented in deno_std. So exported them in js/test_util.ts like done for some others and cleaned the files calling it.

[zekth]

I don't really find why i got those errors. Maybe i'm missing something?

[kevinkassimo]

@zekth Did not check too careful before.

I believe duplicates in util.ts and test_util.ts are intended:

util.ts contents are imported and will be bundled into the generated js file for v8 to take a snapshot and goes into the Deno binary. You'll notice that the imports there does not include the .ts extensions.

test_util.ts is just for testing purposes. All these tests are directly run on Deno, so imports with .ts extensions in that file are fine.

However I do think supporting .ts extensions in the build files might be cool. Not so sure if tweaking ts_library_builder would work for this (I'm never a TypeScript expert)

[zekth]

@zekth Did not check too careful before.

I believe duplicates in util.ts and test_util.ts are intended:

util.ts contents are imported and will be bundled into the generated js file for v8 to take a snapshot and goes into the Deno binary. You'll notice that the imports there does not include the .ts extensions.

test_util.ts is just for testing purposes. All these tests are directly run on Deno, so imports with .ts extensions in that file are fine.

That's exactly what i just figured out. Closing it, i was totally wrong. Sorry guys.