Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: faster node globals access in cjs #19997

Merged
merged 6 commits into from Jul 31, 2023
Merged

perf: faster node globals access in cjs #19997

merged 6 commits into from Jul 31, 2023

Conversation

lucacasonato
Copy link
Member

No description provided.

bartlomieju
bartlomieju approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this fixes the performance problems in npm:express and npm:ws packages.

@bartlomieju bartlomieju enabled auto-merge (squash) July 31, 2023 16:02
@bartlomieju bartlomieju merged commit 78ceeec into main Jul 31, 2023
11 checks passed
@bartlomieju bartlomieju deleted the fast_node_access_cjs branch July 31, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucacasonato @bartlomieju