Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): update imports on file rename #20245

Merged
merged 2 commits into from Aug 26, 2023
Merged

feat(lsp): update imports on file rename #20245

merged 2 commits into from Aug 26, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@bartlomieju bartlomieju added this to the 1.37 milestone Aug 24, 2023
bartlomieju
bartlomieju reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have one question before this one is ready to land

cli/lsp/language_server.rs Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Exciting fix

@bartlomieju bartlomieju merged commit 6f077eb into denoland:main Aug 26, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the rewrite-imports-on-file-rename branch August 26, 2023 00:57
@nayeemrmn nayeemrmn mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

Update imports when filename changes
2 participants
@nayeemrmn @bartlomieju