fix(ext/node/ops/zlib/brotli): Allow decompressing more than 4096 bytes

[lachrimae]

See issue #19816

In that issue, I suggest switching over the other brotli functionality to the Rust API provided by the brotli crate. Here, I only do that with the brotli_decompress function to fix the bug with buffers longer than 4096 bytes.

A good follow-up might be to repeat this change throughout the rest of the module. That will involve some actual work though, because the Node.js Brotli API is presumably based on the C google/brotli API, so an adapter layer in this module to map a Node.js Brotli API to the Rust API would end up being a little more complicated.

[CLAassistant]

All committers have signed the CLA.

[lachrimae]

To project maintainers: I haven't been able to test this locally. There is some sort of issue where my test_util/std folder is empty, but tests expect it to have contents. Any advice on what's going on there? Is there a setup command I need to run?

EDIT: nevermind, I see that they are git submodules.

[littledivy]

LGTM!

an adapter layer in this module to map a Node.js Brotli API to the Rust API would end up being a little more complicated.

Yes, thats why this module was written using the C API. We can use the Rust API for decompression but compression has a lot more flags https://nodejs.org/api/zlib.html#class-brotlioptions and no way to pass them using the Rust API.

EDIT: there are compression options https://docs.rs/brotli/latest/brotli/enc/backward_references/struct.BrotliEncoderParams.html

[lachrimae]

@littledivy okay cool, thank you for explaining those decisions! Would it be of value to the project if I created an adapter layer here, and in the result remove some unsafe code? Or is the Deno team fine with unsafe when used like this? I am a newcomer to the project, so I don't 100% know what the goals and values are 😃

[nberlette]

What needs to happen for us to merge this branch? I'm working on a project right now that's at a complete standstill without a working brotli implementation in Deno 😣

[littledivy]

Thanks for the ping @nberlette