Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/crypto): remove EdDSA alg key checks and export #20331

Merged
merged 1 commit into from Aug 31, 2023
Merged

fix(ext/crypto): remove EdDSA alg key checks and export #20331

merged 1 commit into from Aug 31, 2023

Conversation

panva
Copy link
Contributor

@panva panva commented Aug 30, 2023

As per WICG/webcrypto-secure-curves#24 this removes the check for Ed25519 JWK alg during importKey and removes the alg for Ed25519 keys during JWK exportKey.

@panva panva changed the title crypto: remove webcrypto EdDSA key checks and properties fix(ext/crypto): remove EdDSA alg key checks and export Aug 30, 2023
@panva
Copy link
Contributor Author

panva commented Aug 30, 2023

cc @littledivy

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@littledivy littledivy merged commit 9d58c89 into denoland:main Aug 31, 2023
13 checks passed
@panva panva deleted the crypto-update-eddsa-alg branch August 31, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants