fix(init): skip existing files instead of erroring #20434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsherret
approved these changes
Sep 9, 2023
dsherret
reviewed
Sep 9, 2023
dsherret
reviewed
Sep 9, 2023
dsherret
changed the title
auto-merge was automatically disabled
September 9, 2023 19:32
Head branch was pushed to by a user without write access
bartlomieju
reviewed
Sep 9, 2023
|
@leighmcculloch looks good! Can you please update the test assertion to make CI happy? |
|
@bartlomieju Fixed in 110ed03 and test passes locally. Could you approve CI to rerun? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Skip writing files from the template if the files already exist in the project directory.
Why
When I run deno init in a directory that already has a main.ts, or one of the other template files, I usually want to initialize a workspace around a file I've started working in. A hard error in this case seems counter productive. An informational message about what's being skipped seems sufficient.
Close #20433