fix: exclude internal JS files from coverage #20448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Sep 11, 2023
cli/tools/coverage/mod.rs
Outdated
| @@ -127,6 +127,11 @@ impl CoverageCollector { | |||
|
|
|||
| let script_coverages = self.take_precise_coverage().await?.result; | |||
| for script_coverage in script_coverages { | |||
| // Filter out internal JS files from being included in coverage reports | |||
| if script_coverage.url.starts_with("ext:") || script_coverage.url.starts_with("[ext:") { | |||
There was a problem hiding this comment.
node: should also be excluded
There was a problem hiding this comment.
Seems like this is already happening because internally node:* is resolved to ext:deno_node/*. I'll add a test case for that regardless, because it's good to ensure that we don't regress on this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
deno test --coverage=...behavior so that internal deno JS files are excluded.Fixes #20447