Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): include source in auto import completion label #20523

Merged
merged 3 commits into from Sep 16, 2023
Merged

feat(lsp): include source in auto import completion label #20523

merged 3 commits into from Sep 16, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Sep 16, 2023 •
edited

nayeemrmn
nayeemrmn commented Sep 16, 2023
View reviewed changes
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn removed the request for review from bartlomieju September 16, 2023 05:45
bartlomieju
bartlomieju approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@lucacasonato
Copy link
Member

So awesome!!

@nayeemrmn nayeemrmn merged commit d13e6e6 into denoland:main Sep 16, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the auto-import-label-source branch September 16, 2023 16:15
This was referenced Sep 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show source module name in auto-import suggestions
3 participants
@nayeemrmn @lucacasonato @bartlomieju