Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): pass quote preference to tsc #20547

Merged
merged 5 commits into from Sep 18, 2023
Merged

fix(lsp): pass quote preference to tsc #20547

merged 5 commits into from Sep 18, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #16083. Follow up to #20184. Quote config was in UserPreferences rather than FormatCodeSettings so I missed it before.

@nayeemrmn nayeemrmn added this to the 1.37 milestone Sep 18, 2023
dsherret
dsherret requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a test in lsp_tests.rs?

dsherret
dsherret approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nayeemrmn nayeemrmn merged commit 86c04f4 into denoland:main Sep 18, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the single-quote-config-to-tsc branch September 18, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

lsp: respect fmt configuration
2 participants
@nayeemrmn @dsherret