Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: make deno test 10x faster #20550

Merged
merged 9 commits into from Sep 19, 2023
Merged

perf: make deno test 10x faster #20550

merged 9 commits into from Sep 19, 2023

Conversation

lucacasonato
Copy link
Member

No description provided.

littledivy
littledivy reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

mmastrac
mmastrac reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick notes re: op2 and #[smi]

cli/js/40_testing.js Outdated Show resolved Hide resolved
cli/js/40_testing.js Outdated Show resolved Hide resolved
cli/ops/testing.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice that this logic has been moved to Rust 👍

@lucacasonato lucacasonato merged commit 2772d30 into main Sep 19, 2023
13 checks passed
@lucacasonato lucacasonato deleted the 10x_faster_deno_test branch September 19, 2023 10:10
@lucacasonato lucacasonato mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac left review comments

@littledivy littledivy littledivy left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lucacasonato @mmastrac @marvinhagemeister @bartlomieju @littledivy