Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): ensure that an exception in getOwnPropertyDescriptor('constructor') doesn't break Deno.inspect #20568

Merged
merged 3 commits into from Sep 19, 2023
Merged

fix(cli): ensure that an exception in getOwnPropertyDescriptor('constructor') doesn't break Deno.inspect #20568

merged 3 commits into from Sep 19, 2023

Conversation

mmastrac
Copy link
Member

Fixes #20561

dsherret
dsherret approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) September 19, 2023 16:00
@dsherret dsherret merged commit 612818d into denoland:main Sep 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.inspect may throw if getOwnPropertyDescriptor throws for a constructor
2 participants
@mmastrac @dsherret