perf(ext/fetch): use new instead of createBranded

[marcosc90]

This PR optimizes fromInner* methods of Request / Header / Response used by Deno.serve and fetch by using new instead of ObjectCreate from createBranded.

The "brand" is created by passing webidl.brand to the constructor instead.

deno/ext/webidl/00_webidl.js

Lines 1001 to 1005 in 142449e

	function createBranded(Type) {
	const t = ObjectCreate(Type.prototype);
	t[brand] = brand;
	return t;
	}

Benchmark

const createBranded = Symbol("create branded");
const brand = Symbol("brand");
class B {
  constructor(init) {
    if (init === createBranded) {
      this[brand] = brand;
    }
  }
}

Deno.bench("Object.create(protoype)", () => {
  Object.create(B.prototype);
});

Deno.bench("new Class", () => {
  new B(createBranded);
});

cpu: 13th Gen Intel(R) Core(TM) i9-13900H
runtime: deno 1.37.0 (x86_64-unknown-linux-gnu)

benchmark                    time (avg)        iter/s             (min … max)       p75       p99      p995
----------------------------------------------------------------------------- -----------------------------
Object.create(protoype)       8.74 ns/iter 114,363,610.3    (7.32 ns … 26.02 ns)   8.65 ns  13.39 ns  14.47 ns
new Class                     3.05 ns/iter 328,271,012.2      (2.78 ns … 9.1 ns)   3.06 ns   3.46 ns    3.5 ns

[mmastrac]

Is this[init] = init faster? It should have two less property lookups

[marcosc90]

Good catch, missed that.

[mmastrac]

Because of the way v8 optimizes classes, it might be faster to pass all of these into the constructor after the brand, so that the object always has the same shape after the constructor returns.

new Request(webidl.brand, inner, signal, () => ...);

[marcosc90]

I'll run some benchmarks

[mmastrac]

👍

[mmastrac]

LGTM! We can do a follow-up if passing constructor args helps as well