Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): show related information for tsc diagnostics #20654

Merged
merged 1 commit into from Sep 24, 2023
Merged

fix(lsp): show related information for tsc diagnostics #20654

merged 1 commit into from Sep 24, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #15472.

marvinhagemeister
marvinhagemeister approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@nayeemrmn nayeemrmn merged commit d955d66 into denoland:main Sep 24, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-tsc-diagnostic-related-information branch September 24, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: not properly providing associated information in diagnostic messages
2 participants
@nayeemrmn @marvinhagemeister