Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): cache all dependencies quick fix #20665

Merged
merged 4 commits into from Sep 24, 2023
Merged

feat(lsp): cache all dependencies quick fix #20665

merged 4 commits into from Sep 24, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Sep 24, 2023 •
edited

Closes #16082.
Closes #20658.

Does some refactors suggested by @dsherret in #20632:

  • Extract DiagnosticsServer::state to a language_server::Inner::state, which is passed to DiagnosticsServer::new().
  • Internalize DiagnosticsState's locking and mutability.

I haven't done #20632 (comment). Not sure what design to go for and I don't want to mess with the publishing logic in the same PR.

dsherret
dsherret reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on everything and thanks for making the lsp much better!

I think we can change DiagnosticsState to use a non-async rwlock.

cli/lsp/diagnostics.rs Outdated Show resolved Hide resolved
cli/lsp/diagnostics.rs Outdated Show resolved Hide resolved
cli/lsp/language_server.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nayeemrmn
nayeemrmn commented Sep 24, 2023
View reviewed changes
cli/lsp/language_server.rs Outdated Show resolved Hide resolved
dsherret
dsherret reviewed Sep 24, 2023
View reviewed changes
cli/lsp/diagnostics.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit bb4b00d into denoland:main Sep 24, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-cache-all-code-action branch September 25, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp - Do not pass around RwLock in DiagnosticsServer lsp: quickfix: cache all
2 participants
@nayeemrmn @dsherret