Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): don't call undefined nextTick fn #20724

Merged

Conversation

lucacasonato
Copy link
Member

The process global is not defined in this file.

Fixes #20441

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a test? the original issue provided a reproduction

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit d5b6c63 into denoland:main Oct 2, 2023
13 checks passed
@bartlomieju bartlomieju deleted the process_nextTick_without_process branch October 2, 2023 12:14
bartlomieju added a commit that referenced this pull request Oct 12, 2023
The `process` global is not defined in this file.

Fixes #20441

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno on Windows with Typescript obscures errors
3 participants