Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unstable/byonm): improve error messages #20987

Merged
merged 4 commits into from Oct 27, 2023
Merged

fix(unstable/byonm): improve error messages #20987

merged 4 commits into from Oct 27, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 26, 2023 •
edited

This improves the error messages when a specifier can't be resolved from a deno module into an npm package.

Part of #18967

bartlomieju
bartlomieju approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not sure on the wording for the error.

cli/resolver.rs Outdated Show resolved Hide resolved
@dsherret dsherret merged commit 9026f20 into denoland:main Oct 27, 2023
13 checks passed
@dsherret dsherret deleted the byonm_better_errors branch October 27, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju