Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/ffi): use anybuffer for op_ffi_buf_copy_into #21006

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix(ext/ffi): use anybuffer for op_ffi_buf_copy_into #21006

merged 1 commit into from
Oct 28, 2023

Conversation

littledivy
Copy link
Member

Fixes #21005

@littledivy littledivy enabled auto-merge (squash) October 28, 2023 06:32
aapoalas
aapoalas approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit 5b2d9fb into denoland:main Oct 28, 2023
13 checks passed
@littledivy littledivy deleted the fix_ffi_copy_into branch October 28, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

@mmastrac mmastrac Awaiting requested review from mmastrac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 ffi: ptrView.copyInto(arr) now causes a TypeError (regression between v1.37.1 and v1.37.2)
2 participants
@littledivy @aapoalas